Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #32 highlighted a problem with the simple approach (
strings.Fields
) to splitting a command string into a suitable slice of strings forexec.Command
. A program like this:didn't work as expected, because the actual slice of strings passed to the command was:
which causes the shell to choke. We need a slightly smarter approach which takes into account quoted strings, and doesn't split them:
The creachadair/shell library provides a facility (
Split
) to do exactly this. Thanks to @shumin1027 for the original report, @posener for input, and @jrswab for an initial draft PR on this.