-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTF8 characters in presets not rendering correctly on M1 macOS, v3.2.x #2647
Comments
What is the codepoint of these characters? |
⮜ and ⮞ I was working from this list: https://github.com/bitfocus/companion/wiki/Text-input but didn't encode using the number - just copy-pasted the actual character into the code. It worked on Windows so I thought I'd done it correctly. This can be seen on line 11 of actions.js |
Sorry, that got decoded. I'll try again: |
This is not a bug of the zinc-oscpoint module. It should work exactly like you are doing it. I use unicode characters a lot in perests the same way. Are unicode characters working when you paste them directly in the button text line on M1 or is this a problem only for presets? |
This was reported to me by another user who was giving OSCPoint a spin during an event yesterday. All my testing has been on Windows and Intel macOS - but I'll spin this up on an M1 MacBook tomorrow and see what happens. Assuming my wife lets me borrow her machine. |
I can confirm that chrome and safari on both m1 mac and chrome and companion on ubuntu are unable to render those characters. My first thought was maybe the characters are missing from the font files we are using, but they are present in NotoSansSymbols2-Regular.ttf. |
Oh right ok, so the canvas will only use the first font that we tell it to use and if the character is not in that font it will show the empty box (or similar depending on platform?) mono/SkiaSharp#232 (comment) So I suspect that a font is bleeding through from the OS to fill the characters not available in the font we are drawing with. Maybe this would be fixed by a different canvas library (as well as fixing the 'problem' that |
It seemd to me that this was an old issue. I did try a lot of different fonts and combinations of fonts and on the intel mac the font fallback is working. First our built in fonts are used in the given order and then there is a fallback to the system fonts. Edit: @Julusian, I just did see you found the issue yourself and did allready a fix. Is it working? |
I'm not 100% happy with how the code looks, but I am happy with how that #2648 behaves. I've merged it into beta now, let me know if it doesn't work for you |
The text was updated successfully, but these errors were encountered: