[BUG] Changing connection label error

[thedist]

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

When changing the label of an existing connection, the config tab in the Web UI displays the error Failed to save connection config: "" is not a valid variable id and the console has the error

warn UI/Handler Error in client handler 'connections:set-config': Error: "" is not a valid variable id Error: "" is not a valid variable id
    at SplitVariableId (/lib/Resources/Util.js:338:31)
    at VisitorReferencesUpdater.visitVariableName (/lib/Util/Visitors/ReferencesUpdater.js:138:14)
    at visitEventOptions (/lib/Resources/EventDefinitions.js:188:11)
    at DataImportExport.visitControlReferences (/lib/Data/ImportExport.js:1309:4)
    at DataImportExport.fixupControlReferences (/lib/Data/ImportExport.js:1326:8)
    at ControlTrigger.renameVariables (/lib/Controls/ControlTypes/Triggers/Trigger.js:617:51)
    at ControlsController.renameVariables (/lib/Controls/Controller.js:1564:12)
    at InstanceVariable.connectionLabelRename (/lib/Instance/Variable.js:254:17)
    at Instance.setInstanceLabelAndConfig (/lib/Instance/Controller.js:167:18)
    at /lib/Instance/Controller.js:580:10

Pressing 'save' on the config following this error the label change appears to work without issue.

This occurs on all modules that I have tested.

Steps To Reproduce

1. Create a connection to a module, for example Generic HTTP
2. Edit the label of the connection and click save
3. An error will be displayed. You can either click Save again to save the new label, or disable/enable the connection also seems to load the label that was saved during the error

Expected Behavior

The label should be updated without throwing an error (unless there is some sort of conflict with another label, or using characters that may not be allowed in the label).

Environment (please complete the following information)

- OS: Win 10
- Browser: Google Chrome 120.0.6099.225
- Companion Version: 3.3.0+6693-main-790985a1 (issue also present in 3.2.0+6647-beta-5aec8e7e)

Additional context

No response

[Julusian]

This also needs something like

to reproduce the issue.
This has a slightly different error, but is in the same area and the same root cause

[Julusian]

this is fixed in v3.2.1 and beta