Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test #111

Merged
merged 9 commits into from
Jan 17, 2020
Merged

Regression test #111

merged 9 commits into from
Jan 17, 2020

Conversation

jamieabc
Copy link
Contributor

This modification adds an internal hasher which is used when chain is local. The advantages of internal hasher is to faster local development/testing, so that whatever the block hash is always valid.

Following changes are made:

  1. When chain is local, block digest checking is always success
  2. internal hasher is started when chain is local, thus no longer needs extra program recorderd

@jamieabc jamieabc requested a review from hxw December 25, 2019 09:37
@nodestory
Copy link
Contributor

#101

@nodestory nodestory added this to the Q12020 milestone Jan 2, 2020
@hxw hxw removed the do not merge label Jan 17, 2020
@jamieabc
Copy link
Contributor Author

test this please

@hxw hxw merged commit 25e9e75 into master Jan 17, 2020
@hxw hxw deleted the regression-test branch January 17, 2020 03:52
@jamieabc jamieabc mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hxw hxw hxw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Q12020
Development

Successfully merging this pull request may close these issues.
3 participants
@jamieabc @nodestory @hxw