Feature/multiple audio representations #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2017 16:43
msmole
reviewed
Feb 28, 2017
| $audioGroupId = 'audio'; | ||
| if ($codecConfigContainer->apiCodecConfiguration instanceof AACAudioCodecConfiguration) | ||
| { | ||
| $audioGroupId = 'audio'; |
There was a problem hiding this comment.
How does this work if there are multiple qualities with different audio group ids?
There was a problem hiding this comment.
Because then $output->audioVideoGroups is not null, and this code is not reached.
msmole
approved these changes
Feb 28, 2017
rkersche
pushed a commit
that referenced
this pull request
Feb 28, 2017
…ions Feature/multiple audio representations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.