Feature/mp4 muxing example #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hpDocs for improved autoCompletion
… able to identify each config
…fic configuration
rkersche
reviewed
Nov 22, 2016
| private static function createFMP4Muxing(Encoding $encoding, Stream $stream, $output, $outputPath, ApiClient $apiClient) | ||
| { | ||
| $encodingOutput = null; | ||
| if ($output != null && $outputPath != null) | ||
| $encodingOutput = NULL; |
There was a problem hiding this comment.
As it basically a constant, I tend to write null, true, false in uppercase. However, reverted it
rkersche
reviewed
Nov 22, 2016
| @@ -129,28 +211,33 @@ public static function createMuxingForEncoding(JobContainer $jobContainer, Encod | |||
| { | |||
| $smoothStreamingOutputFormat = $format; | |||
| } | |||
| if ($format instanceof ProgressiveMp4OutputFormat) | |||
| { | |||
| $progressiveMp4OutputFormats[] = $format; | |||
There was a problem hiding this comment.
Instead of introducing a new variable here, you could do this check in static::createMP4MuxingsForEncoding
There was a problem hiding this comment.
moved all the related code into createMP4MuxingsForEncoding()
…sive muxing related into createMP4MuxingsForEncoding()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.