Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate release on merge in develop #590

Merged
merged 31 commits into from
Dec 29, 2023
Merged

Automate release on merge in develop #590

merged 31 commits into from
Dec 29, 2023

Conversation

mukulmishra18
Copy link
Contributor

@mukulmishra18 mukulmishra18 commented Dec 27, 2023 •
edited
Loading

We need to automate the release.

This PR automate the release on every PR merge in develop branch.

@mukulmishra18 mukulmishra18 self-assigned this Dec 27, 2023
@mukulmishra18
Push tag without using github token
531c5c2
@mukulmishra18
Set upstream during push to origin
afd5736
@mukulmishra18
Access output variables from outputs namespace
42b7482
@mukulmishra18
Use temp branch for testing
e75fa8f
@mukulmishra18
Use workflow_dispatch instead of pr merge event for testing
af1b347
@mukulmishra18
Revert triggering of workflow on workflow_dispatch event
06f6320
@mukulmishra18
Use steps namespace to access the output
3719aa1
@mukulmishra18
Use script instead of run
a96bd78
@mukulmishra18
Move checkout step up in the workflow
9997901
@mukulmishra18
Remove token usage
4405794
@mukulmishra18
Add semver in dev-dependencies
8d85dd3
@mukulmishra18
Restructure the workflow
13eaea9
@mukulmishra18
Fix npm version command
c849cb4
@mukulmishra18
Move git configure before bumping npm version
4aae50a
@mukulmishra18
Update workflow and job name
001adf5
@mukulmishra18
Remove triggering workflow on push event
a527d5b
@mukulmishra18
Add unit test for defineVersion
f458495
@mukulmishra18
Use develop branch instead of testing branch
a71d0bc
@mukulmishra18
Fix indentation
df64254
@mukulmishra18 mukulmishra18 marked this pull request as ready for review December 28, 2023 11:53
offnertho
offnertho requested changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@offnertho offnertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

Some small remarks.

.github/workflows/merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
offnertho
offnertho reviewed Dec 29, 2023
View reviewed changes
.github/scripts/defineVersion.js Outdated Show resolved Hide resolved
.github/workflows/release-on-merge.yml Outdated Show resolved Hide resolved
.github/workflows/release-on-merge.yml Outdated Show resolved Hide resolved
.github/workflows/release-on-merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
.github/workflows/merge.yml Outdated Show resolved Hide resolved
offnertho
offnertho approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@offnertho offnertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I guess when this is merged we need to cancel the release that is triggered with this?

@mukulmishra18 mukulmishra18 merged commit c59dee7 into develop Dec 29, 2023
2 checks passed
@mukulmishra18 mukulmishra18 deleted the feature/automate-release-on-merge branch December 29, 2023 12:38
@mukulmishra18 mukulmishra18 mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offnertho offnertho offnertho approved these changes

Assignees

@mukulmishra18 mukulmishra18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukulmishra18 @offnertho