-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/keycloak] set Statefulset specific annotations #24011
Comments
Hi! Did you try this?
Not sure if that would be enough or you would need a specific one for the statefulset object. |
Hi @javsalgar , It's actually to use it with stakater/reloader, so that keycloak can reload on a change of, for instance, certificates or some secret containing the database password. E.g.
Will restart the SS on every change of any mounted secret/configmap (pretty cool stuff btw) More info in: https://github.com/stakater/Reloader So it must be on the top level statefulset unfortunately. |
Awesome, then please let us know when you submit the PR and we will take a look. Thank you so much! |
@javsalgar PR was created, I've added a field "statefulsetAnnotations", to be somewhat in line with "commonAnnotations" but I'll hear it from you or the community if this is the way |
Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close. Your contribution is greatly appreciated! |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary. |
Name and Version
bitnami/keycloak:*
What is the problem this feature will solve?
for some stuff, e.g. stakater reloader, annotations need to be set on a statefulset (or deployment or whatever you want to "reload" on a change).
Currently I can add this via commonAnnotations but this pollutes everything in this case as it is only needed (and wanted) for the statefulset
What is the feature you are proposing to solve the problem?
allow something like statefulset.annotation or statefulset.extraAnnotations so that secret.reloader.stakater.com/reload can be set
What alternatives have you considered?
Using commonAnnotations but that pollutes everything (and also this [secret.reloader.stakater.com/reload] would be strange to see on the other resources)
The text was updated successfully, but these errors were encountered: