Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/keycloak] set Statefulset specific annotations #24011

Closed
UXabre opened this issue Mar 1, 2024 · 7 comments
Closed

[bitnami/keycloak] set Statefulset specific annotations #24011

UXabre opened this issue Mar 1, 2024 · 7 comments
Assignees
Labels
feature-request keycloak solved stale 15 days without activity triage Triage is needed

Comments

@UXabre
Copy link
Contributor

UXabre commented Mar 1, 2024

Name and Version

bitnami/keycloak:*

What is the problem this feature will solve?

for some stuff, e.g. stakater reloader, annotations need to be set on a statefulset (or deployment or whatever you want to "reload" on a change).
Currently I can add this via commonAnnotations but this pollutes everything in this case as it is only needed (and wanted) for the statefulset

What is the feature you are proposing to solve the problem?

allow something like statefulset.annotation or statefulset.extraAnnotations so that secret.reloader.stakater.com/reload can be set

What alternatives have you considered?

Using commonAnnotations but that pollutes everything (and also this [secret.reloader.stakater.com/reload] would be strange to see on the other resources)

@github-actions github-actions bot added the triage Triage is needed label Mar 1, 2024
@javsalgar
Copy link
Contributor

Hi!

Did you try this?

## @param podAnnotations Annotations for Keycloak pods
## ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
##
podAnnotations: {}

Not sure if that would be enough or you would need a specific one for the statefulset object.

@UXabre
Copy link
Contributor Author

UXabre commented Mar 4, 2024

Hi @javsalgar ,

It's actually to use it with stakater/reloader, so that keycloak can reload on a change of, for instance, certificates or some secret containing the database password.

E.g.

kind: StatefulSet
metadata:
  annotations:
    reloader.stakater.com/auto: "true"
spec:
  template:
    metadata:
    ....

Will restart the SS on every change of any mounted secret/configmap (pretty cool stuff btw)

More info in: https://github.com/stakater/Reloader

So it must be on the top level statefulset unfortunately.
BTW, I am willing to implement this, haven't come around to it just yet

@javsalgar
Copy link
Contributor

Awesome, then please let us know when you submit the PR and we will take a look. Thank you so much!

@UXabre
Copy link
Contributor Author

UXabre commented Mar 5, 2024

@javsalgar PR was created, I've added a field "statefulsetAnnotations", to be somewhat in line with "commonAnnotations" but I'll hear it from you or the community if this is the way

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Mar 21, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request keycloak solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

No branches or pull requests

4 participants