Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 juan@bitnami.com
This PR fixes the issue described below when running
ini-file
with an unprivileged user:When we have a “non-root” container run as
1001:root
and we have a file with the permissions below:The user can write in the file since it belongs to the
root
group. However, running the command below will fail:The reason is how
ini-file
perform write operations. It's usingsafefile
that create a temporal file, to replace the destination file with this temporal file later. This temporal file is created with-rw-r-r-- 1001:root
permissions, which is wrong for two reasons:We tried to fix this by running some chown/chmod operations but it's not working since "chown" operations require privilege permissions.
Solution: stop using
safefile
and directly write in the destination.