Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can.Observe sort plugin doesn't trigger add events. #205

Closed
imjoshdean opened this issue Dec 13, 2012 · 1 comment
Closed

can.Observe sort plugin doesn't trigger add events. #205

imjoshdean opened this issue Dec 13, 2012 · 1 comment
Assignees
@daffl
Labels
bug
Milestone
1.1.4

Comments

@imjoshdean
Copy link
Contributor

It seems that the can.Observe sort plugin doesn't handle triggering add events, which makes it pretty useless. This wasn't caught because the expected number of passed tests was never specified.

The correct number of passing tests has been added in commit 4aad9d7, but now needs to be resolved.
@daffl
Copy link
Contributor

daffl commented Dec 18, 2012

That sort plugin needs some serious fixing up #170 and #88 are probably related as well and should be fixed all together.

@ghost ghost assigned daffl Dec 18, 2012
@daffl daffl mentioned this issue Dec 31, 2012
Merged
@daffl daffl closed this as completed in 9acf5e5 Dec 31, 2012
daffl added a commit that referenced this issue Dec 31, 2012
@daffl
Merge pull request #219 from bitovi/sort-plugin-170-205
19aa192 
Trigger add event for sorted lists. Closes #170, closes #205
@daffl daffl mentioned this issue Jan 16, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daffl daffl

Labels
bug
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
2 participants
@imjoshdean @daffl