Prevent leak from computes that have no bindings. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the same event triggers an update to a compute AND the same event also unbinds the compute, it can result in the compute having bindings = 0, but still haveing a bound onchanged handler. This results in unecessary recomputes and can leak Models in the Model store.
|
very cool! |
daffl
added a commit
that referenced
this pull request
Mar 15, 2013
Prevent leak from computes that have no bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same event triggers an update to a compute AND
the same event also unbinds the compute, it can result in
the compute having bindings = 0, but still haveing a bound
onchanged handler.
This results in unecessary recomputes and can leak Models in
the Model store.
I know the test case seems very esoteric, but it's actually quite easy to get into this situation with live binding:
{{#if computeA}} {{#if computeB}} <span>Whatever</span> {{/if}} {{/if}}Whenever computeA = false, computeB should be unbound (since it is no longer rendered), but because the same event that unbinds computeB also triggers a recompute of B, B's onchanged handler will still be called, even though bindings === 0. It then binds normally, which causes the leak, since teardown has already been called and the original bindings context is lost.