Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already merged this fix into the 1.2 develop branch with #309 but suggest to make this part of the 1.1.5 release as well. All tests are still passing and it doesn't introduce a new API. The fix makes this possible:
Since
new Observe({ 'test.key': 'value' })
failed before, introducing the direct key lookup forobsreve.attr('test.key')
(and falling back to the nested property lookup if it doesnt' exist) shouldn't pose a problem for any existing functionality. Fixes #257 and #296.