Outputting attribute and value containing '=' truncates the value (EJS & Mustache) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
daffl
added a commit
that referenced
this pull request
Apr 8, 2013
Outputting attribute and value containing '=' truncates the value (EJS & Mustache)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an HTML attribute is output using EJS or Mustache, any value that has a '=' in it will be truncated when live binding updates it. This can be observed in the fiddle below:
http://jsfiddle.net/NMvAd/
This is a problem particularly for src since the workaround to avoid an initial 404 (#157) involves outputting
src=along with the value.The problem is in render.js, specifically the update function that runs when you are in a tag, but not an attribute.