Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.EJS template rendering issue #118

Merged
merged 1 commit into from
Jan 11, 2013
Merged

can.EJS template rendering issue #118

merged 1 commit into from
Jan 11, 2013

Conversation

daffl
Copy link
Contributor

@daffl daffl commented Jan 11, 2013

can.EJS while rendering a template wrongly substituting value when value has a null

can.EJS({text:'<%=name%>'})({name:'namenullname'}) will return "name&#34;name"

using <%==name%> will fix it temporarily, but that is more risky to use.

@daffl
Copy link
Contributor

daffl commented Oct 16, 2012

This is fixed in the current master and will be part of the next version. I will also try to get the build back up so that you can create your own version.

@daffl daffl closed this Oct 16, 2012
@ravihamsa
Copy link
Author

I did download 1.1.3 version, this problem is still there. is this really resolved?

@daffl
Copy link
Contributor

daffl commented Dec 18, 2012

You are right. Seems like escaping does something weird here. Reopening.

@daffl daffl reopened this Dec 18, 2012
@ghost ghost assigned daffl Dec 31, 2012
@daffl
Copy link
Contributor

daffl commented Jan 11, 2013

Finally fixed it. It was name clash that replaced a regular expression with null in the actual build. Will merge and put into 1.1.4.

daffl added a commit that referenced this pull request Jan 11, 2013
can.EJS template rendering issue #118
@daffl daffl merged commit 652043b into master Jan 11, 2013
@daffl daffl deleted the nameclash-118 branch January 11, 2013 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants