String parameter not working as expected for: jQuery.fn.control / jQuery.fn.controls

[daffl]

Using CanJS v1.1.6

String parameter not working as expected for: jQuery.fn.control / jQuery.fn.controls

Reference: http://canjs.com/docs/jQuery.fn.control.html

//
//  Define Plugin
//
var MyPlugin = can.Control.extend('MyPlugin', {
  pluginName: 'MyPlugin'
}, {});

// init plugin
$('body').MyPlugin();


//
//  Attempt to get defined plugin
//
$('body').control(); // returns MyPlugin (works as expected)
$('body').control(); // returns MyPlugin (works as expected)
$('body').control(MyPlugin); // returns MyPlugin (works as expected)

$('body').control('MyPlugin');  // returns undefined
$('body').control('myplugin'); // return undefined

[tilleps]

Turns out that the string parameter will need to be converted with can.underscore()

$('body').control('MyPlugin');  // returns undefined
$('body').control( can.underscore('MyPlugin') ); // returns MyPlugin
$('body').control('my_plugin'); // returns MyPlugin

This does not seem intuitive as initializing the plugin is done with the string defined in pluginName

$('body').MyPlugin();  // initializes
$('body').my_plugin(); // Error: has no method 'my_plugin'

Notes/examples of this behavior would be helpful on the documentation page
http://canjs.com/docs/jQuery.fn.control.html

[tilleps]

Another note, the fullName parameter can.Control() must also be provided in order for control() and controls() to match a control.

Would there be any issues assigning pluginName as fullName if fullName is not provided?

//
// Instead of having to manually assign fullName and pluginName
//
var MyPlugin = can.Control.extend('MyPlugin', {
  pluginName: 'MyPlugin'
}, {});

//
// Allow this instead
//
var MyPlugin = can.Control.extend({
  pluginName: 'MyPlugin'
}, {});


MyPlugin.fullName;  // return undefined (currently)
MyPlugin.fullName;  // returns MyPlugin (proposed)

[daffl]

Thanks! These docs are definitely not up-to date. I will have a look at it today.

[daffl]

This was actually a bug which is fixed now with the attached pull request. Documentation has been updated as well.