Fixing truncation of special attribute (src and style) values containing '=' #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccummings can you write a new test instead of modifying the old one? As a div and image each take a separate path when being live-bound, we should keep a test for both cases. |
|
I'm going to merge. @ccummings please add this in for 2.1. |
justinbmeyer
added a commit
that referenced
this pull request
Feb 4, 2014
Fixing truncation of special attribute (src and style) values containing '='
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact same issue as #342 except with
srcandstylewhich are considered special attributes. Values for special attributes are passed to getValue where they are run through a few regex.The value passed to getValue has the attribute name in it followed by an
=, so if yoursrcvalue has a '=' in it likemyImage.png?wid=900&hei=450, getValue would be operating onsrc="myImage.png?wid=900&hei=450"and you would end up with450.Fix is to change the attribute regex to take the string after the first
=instead of taking the string after the last=