Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dist folder & add dist folder to .gitignore #103

Closed
wants to merge 1 commit into from
Closed

remove dist folder & add dist folder to .gitignore #103

wants to merge 1 commit into from

Conversation

mickmcgrath13
Copy link
Contributor

with this update, user can simply clone and then npm install without git seeing local changes

@mickmcgrath13 mickmcgrath13 mentioned this pull request Sep 25, 2015
Closed
@daffl
Copy link
Contributor

daffl commented Sep 25, 2015

I'm pretty sure the dist/ folder is checked in to support Bower. It doesn't have to be in master but it at least has to be available in the tags.

@mickmcgrath13
Copy link
Contributor Author

#101

The dist/ folder is generated on npm install. Is that sufficient?

@mickmcgrath13
Copy link
Contributor Author

From #101

@matthewp said:

Yeah, we should gitignore the dist/ folder in master and only publish it in a tag by force adding.

@mickmcgrath13
Copy link
Contributor Author

closing this in lieu of #106

@mickmcgrath13 mickmcgrath13 deleted the issue/101/gitignore-dist branch October 8, 2015 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickmcgrath13 @daffl