Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction_to_Web_Animations_using_CSS_Code_Deliverable #237

Open
wants to merge 8 commits into
base: Driving-the-car-and-flowing-the-water-with-CSS
Choose a base branch
from

Conversation

KathyLiu20
Copy link

@KathyLiu20 KathyLiu20 commented Jun 21, 2020

Reference to issue

Description of the changes proposed in the pull request

  • starter code and solution code
  • written deliverable update

Link to Code SandBox

https://codesandbox.io/s/interesting-kepler-9dnb5?file=/src/styles.css:0-2271

Link to Loom video (if blog/workshop completed)

  • link

Reviewers requested:

- starter code and solution code
@KathyLiu20 KathyLiu20 changed the title Driving_the_car_and_flowing_the_water_with_CSS_Code_Deliverable Introduction_to_Web_Animations_using_CSS_Code_Deliverable Jun 21, 2020
- revised the blog according to feedback
Copy link
Contributor

@atuljayaram atuljayaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious flaw in your code. Great job with it so far. Keep going!

@@ -10,7 +10,8 @@ In this blog, we are going to keep building our mini city. We will have a car go

First, let's build our car and boat with HTML and CSS like we did for the ground and buildings previously.
The car is a rectangle box and the boat is a rectangle box with a triangle in the front. Both of them has a shadow to help show the 3D effect.
So we need to have 2 divs for the car and the boat, and in each of them, we will have some children divs inside.
So we need to have 2 divs for the car and the boat, and in each of them, we will have some children divs inside. Children divs are divs inside a parent div. They are associated to their parent, and can be easily aligned with their parent div. The two children divs under the car are to hold the left and front side rectangles, and the three children divs under the boat are to hold the triangle in the front, and the left and front side rectangles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

KathyLiu20 and others added 2 commits June 21, 2020 13:57
- starter and solution code including background and buildings.
@@ -1,16 +1,17 @@
# Introduction to Web Animations using CSS

In this blog, we are going to keep building our mini city. We will have a car going along the road and the bridge, and a boat going under the bridge.
In this blog, we are going to keep building our mini city. We will have a car going along the road and the bridge as well as a boat going under the bridge.
Copy link

@allenaavila allenaavila Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be helpful to add a few more sentences prepping the reader for this blog. You can add something about how this post is about web animations using CSS and add a link to the previous blog post where you built the mini city (if you can link it).

So we need to have 2 divs for the car and the boat, and in each of them, we will have some children divs inside.
First, let's build our car and boat with HTML and CSS, just like we did for the ground and buildings before.
The car is a rectangle box, and the boat is a rectangle box with a triangle in the front. Both of them have a shadow to help show the 3D-effect.
So we need to have two divs for the car and the boat, and inside each of them, we will have some children divs. Children divs are divs inside a parent div. They are associated to their parent and can be easily aligned with their parent div. The two children divs under the car are to hold the left and front side rectangles while the three children divs under the boat are to hold the triangle in the front and the left and front side rectangles.
Copy link

@allenaavila allenaavila Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're assuming your audience is more new to CSS, you could go in-depth as to what "easily aligned" means to make sure they understand the connection between children and parent divs. What sort of relationship does that mean? How does the parent div affect the children div?


![](https://i.imgur.com/9FFPgkl.gif)



## Build the car and the boat

First, let's build our car and boat with HTML and CSS like we did for the ground and buildings previously.
The car is a rectangle box and the boat is a rectangle box with a triangle in the front. Both of them has a shadow to help show the 3D effect.
So we need to have 2 divs for the car and the boat, and in each of them, we will have some children divs inside.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For numbers under 10 in the text part of your blog post, spell them out

@@ -133,4 +134,4 @@ Similar for the car, but we want the car to go onto the bridge, so we break its
```

## Conclusion

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add more to this conclusion, perhaps expanding on/ suggesting other ways animation can be used for the mini city or other projects. Also, would choose another word choice besides "strong" because it's a bit vague; do you mean something more like "exciting," "impressive," "lively"?




Similar for the car, but we want the car to go onto the bridge, so we break its route into 5 parts.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed like you meant boat here, so I changed it to boat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants