Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps-decompiler 1.0.1 #2874

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

imranMnts
Copy link
Contributor

@imranMnts imranMnts commented Jan 25, 2021

TagCheck

What to do if the build fails?

At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.

New Pull Request Checklist

Please mark the points which you did / accept.

New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.

@imranMnts imranMnts mentioned this pull request Jan 25, 2021
5 tasks
@sylank sylank self-requested a review January 26, 2021 08:56
@sylank
Copy link

sylank commented Jan 26, 2021

Hello, @imranMnts,

I think you forgot to attach the step's icon that you have attached in your previous PR:
https://github.com/bitrise-io/bitrise-steplib/pull/2865/files#diff-2dac4a4271a3cebaa805a4dd509c4a1beae52d2d541c08593b236cbaaef4dd4e

@sylank
Copy link

sylank commented Jan 26, 2021

But I can merge this PR and you can open a new PR with the icon.

@imranMnts
Copy link
Contributor Author

Hello @sylank

I readded it, thanks for the reminder

Copy link

@sylank sylank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@imranMnts Thank you for the contribution 😺

@sylank sylank merged commit 9542075 into bitrise-io:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants