Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileManager.Open #182

Merged
merged 2 commits into from
May 19, 2023
Merged

Add FileManager.Open #182

merged 2 commits into from
May 19, 2023

Conversation

godrei
Copy link
Contributor

@godrei godrei commented May 19, 2023

This PR adds Open function to fileutil.Filemanager, to make it easier to write unit tests for functions opening a file.

@godrei godrei mentioned this pull request May 19, 2023
Closed
@godrei godrei requested a review from vshah23 May 19, 2023 10:44
@godrei godrei merged commit 2c8004d into master May 19, 2023
@godrei godrei deleted the open-file branch May 19, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshah23 vshah23 vshah23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godrei @vshah23