Refined exporting conditions and migrated to Go modules #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istvankovacs-bitrise
changed the title
istvankovacs-bitrise
changed the title
istvankovacs-bitrise
changed the title
lpusok
reviewed
May 12, 2021
| @@ -55,15 +55,15 @@ func installDependency(packageManager jsdependency.Tool, name string, version st | |||
| } | |||
| for i, cmd := range cmdSlice { | |||
| fmt.Println() | |||
| log.Donef("$ %s", cmd.PrintableCommandArgs()) | |||
| log.Donef("$ %s", cmd.Slice.PrintableCommandArgs()) | |||
There was a problem hiding this comment.
In line#52 jsdependency.InstallGlobalDependencyCommand now returns a custom object, containing the model instance, stored in the Slice attribute.
lpusok
reviewed
May 12, 2021
lpusok
approved these changes
May 12, 2021
istvankovacs-bitrise
deleted the
STEP-188-replace-no-app-found-warning-with-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bitrise.atlassian.net/browse/STEP-188
Checklist
Context
Cordova Archive Step does not generate a
.appwhen the target is set todevice(only when it is set toemulator), so there is no need for theno app foundwarning in this case.Changes
no app foundwarning replaced with an error to avoid causing confusion.