New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variable _consecutive_production_enabled #1294

Merged
merged 3 commits into from Aug 29, 2018

Conversation

Projects
3 participants
@zhuliting

zhuliting commented Aug 28, 2018

No description provided.

@abitmore

This comment has been minimized.

Member

abitmore commented Aug 28, 2018

Note: related startup option was removed in this commit: 26007bb

@oxarbitrage

thanks @zhuliting for the work and @abitmore for adding the commit where the code for the option was removed.

@abitmore

This comment has been minimized.

Member

abitmore commented Aug 29, 2018

Perhaps we can remove these as well:

case block_production_condition::consecutive:
elog("Not producing block because the last block was generated by the same witness.\nThis node is probably disconnected from the network so block production has been disabled.\nDisable this check with --allow-consecutive option.");
break;

@zhuliting zhuliting dismissed stale reviews from oxarbitrage and abitmore via ff1fa3f Aug 29, 2018

@abitmore abitmore merged commit 5b8192c into bitshares:develop Aug 29, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ryanRfox ryanRfox added this to In progress in Feature release (201810) via automation Sep 5, 2018

@jmjatlanta jmjatlanta moved this from In progress to Done in Feature release (201810) Sep 17, 2018

@abitmore abitmore added this to the 201810 - Feature Release milestone Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment