remove custom operation plugin check from custom api creation #2033
Conversation
|
Actually the check is correct (and should even be added for other APIs that require plugins as well, see some other issue). Note that even without the check the error will occur if a node doesn't enable the API, which would be pointless if the plugin is not active. |
|
ok, trying something else. |
|
New approach at 860fe96 |
oxarbitrage
changed the title
libraries/wallet/wallet_api_impl.cpp
Outdated
| } | ||
| catch(const fc::exception& e) | ||
| { | ||
| wlog("Custom operations plugin is not loaded."); |
There was a problem hiding this comment.
Better: Custom operations API is not active on server.
What happens in this case if get_account_storage is invoked?
There was a problem hiding this comment.
Better: Custom operations API is not active on server.
Changed.
What happens in this case if get_account_storage is invoked?
Crash, added try to call, thanks :)
Both changes at f6738ec
Note: No need to add try at account_store_map as it does not use the API. custom operations can be created without the plugin or the api being enabled, not possible to read without them.
abitmore
added this to In development
in Protocol Upgrade Release (4.0.0)
via automation
For #2032