Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear operation_results when generating block #2475

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Jun 17, 2021

Clear operation_results when generating block in order to

  • save disk space and network bandwidth, and
  • make it more flexible to store larger data in operation results for various purposes.

Note:

  • this change may break client applications which rely on operation_results fields of get_block API, because newly-generated blocks will have empty operation_results fields, thus the get_block API will return empty operation result vectors for those blocks;
  • after this change, full operation results are still in account history (unchanged).

To save disk space and network bandwidth.
@abitmore abitmore added this to the 5.3.0 - Feature Release milestone Jun 17, 2021
@abitmore abitmore added this to In progress in Feature Release (6.1.0) via automation Jun 17, 2021
@abitmore abitmore force-pushed the no-operation-results-in-block branch from f1bfa63 to 069d87d Compare June 17, 2021 22:25
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant