Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data deletion in es_objects plugin, update program options #2570

Merged
merged 16 commits into from
Dec 29, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Dec 27, 2021

PR for #2464.

Features:

  • Add new option es-objects-sync-db-on-startup to copy all applicable objects from the object database (chain state) to ES on program startup
  • Deprecate the es-objects-keep-only-current option, add new options
    • es-objects-accounts-store-updates, default false
    • es-objects-assets-store-updates, default false
    • es-objects-asset-bitasset-store-updates, default false
    • es-objects-balances-store-updates, default false
    • es-objects-proposals-store-updates, default false
    • es-objects-proposals-no-delete, default true
    • es-objects-limit-orders-store-updates, default false
    • es-objects-limit-orders-no-delete, default false
  • Update default value of es-objects-limit-orders to true

Done some code cleanups and refactory.


Tasks:

  • sync (objects in) ES database from node on startup via --es-objects-sync-db-on-startup option
  • deal with errors on deletion i.e. data does not exist in ES due to out of sync: { ..., "errors":false, "items":[{"delete":{ ..., "result":"not_found", ..., "status":404}}, ... ]}
  • deprecate the keep-only-current option, add dedicated store-updates and no-delete options for each applicable object

@abitmore abitmore added this to In progress in Feature Release (6.1.0) via automation Dec 27, 2021
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Dec 27, 2021
@abitmore abitmore linked an issue Dec 27, 2021 that may be closed by this pull request
17 tasks
@abitmore abitmore marked this pull request as ready for review December 28, 2021 20:32
@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.2% 82.2% Coverage
0.0% 0.0% Duplication

@abitmore abitmore changed the title Fix data deletion in es_objects plugin Fix data deletion in es_objects plugin, update program options Dec 28, 2021
@abitmore abitmore merged commit 302b351 into develop Dec 29, 2021
Feature Release (6.1.0) automation moved this from In progress to Done Dec 29, 2021
@abitmore abitmore deleted the pr-2464-es-objects-delete branch December 29, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ES_objects plugin does not delete data from ES
1 participant