Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete objects from ES before loading from object database #2623

Merged
merged 7 commits into from
Aug 8, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Aug 8, 2022

For #2464 (comment), follow-up of #2570.

  • When syncing from scratch or re-syncing, for the object types that are enabled to be stored in ES, always delete all objects from ES first on node startup.
  • Otherwise, if the es-objects-sync-db-on-startup startup option is true, for the object types that are enabled to be stored in ES and both no-delete and store-updates options are false, delete all objects from ES before loading from the object database.

@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Aug 8, 2022
@abitmore abitmore added this to In progress in Feature Release (6.1.0) via automation Aug 8, 2022
@abitmore abitmore linked an issue Aug 8, 2022 that may be closed by this pull request
17 tasks
@abitmore abitmore marked this pull request as ready for review August 8, 2022 11:24
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit 8e98c4c into develop Aug 8, 2022
Feature Release (6.1.0) automation moved this from In progress to Done Aug 8, 2022
@abitmore abitmore deleted the pr-2464-es-obj-del branch August 8, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ES_objects plugin does not delete data from ES
1 participant