New default config file #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a newly written config file was ignored. For the included plugins that didn't matter though, because all config file options (and their default values) are also CLI options, and CLI defaults always apply, no matter if a config file exists or not. Now, a new config file is written with the default option values (if any), and parsed immediately after that. In other words, the config defaults are applied again. This does not result in a different outcome, at least with the included plugins.
oxarbitrage
approved these changes
Oct 16, 2017
There was a problem hiding this comment.
very nice work. tested it and works perfect, code looks good too. if @xeroc agree we can merge this solution.
|
Nice solution ... much nicer than anything I could have come up with .. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of PR #415
Looks bigger than it is, check the individual commits for better understanding.