Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence wrong tag warning #88

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Silence wrong tag warning #88

merged 1 commit into from
Nov 7, 2018

Conversation

HarukaMa
Copy link

@HarukaMa HarukaMa commented Nov 7, 2018

Somehow variant_object was referenced as struct here while it's actually a class.

Should get rid of related warnings when compiling.

pmconrad
pmconrad approved these changes Nov 7, 2018
View reviewed changes
Copy link

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmconrad pmconrad merged commit 9cce60c into bitshares:master Nov 7, 2018
@pmconrad
Copy link

pmconrad commented Nov 7, 2018

Still requires a bump in core

@nathanielhourt nathanielhourt mentioned this pull request Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarukaMa @pmconrad