Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] Generated password doesn't show completely #1532

Closed
abitmore opened this issue May 19, 2018 · 5 comments
Closed

[1] Generated password doesn't show completely #1532

abitmore opened this issue May 19, 2018 · 5 comments
Assignees
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive
Milestone

Comments

@abitmore
Copy link
Member

Describe the bug
Account creation page, the generated password is too long, or font is too big.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wallet.bitshares.org/#/create-account/password with a new incognito window

Expected behavior
The whole password will show on page

Screenshots
image

Desktop (please complete the following information):

  • OS: Win7
  • Browser Chrome
  • Version latest

Additional context
Add any other context about the problem here.

@abitmore
Copy link
Member Author

Larger screenshot:
image

@happyconcepts
Copy link
Contributor

Probably due to the font size increase.

@wmbutler
Copy link
Contributor

Let's reduce the font size to accommodate. I view this as a serious bug since some users will unwittingly copy and save only a portion of their password. Recommend a hotfix.

@wmbutler wmbutler changed the title Generated password doesn't show completely [1] Generated password doesn't show completely May 20, 2018
@wmbutler wmbutler added [3] Bug Classification indicating the existing implementation does not match the intention of the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive labels May 20, 2018
@wmbutler wmbutler added this to the 180525 milestone May 20, 2018
@startailcoon startailcoon self-assigned this May 26, 2018
@startailcoon
Copy link
Contributor

startailcoon commented May 26, 2018

Desktop

image

With an decreased font size, we can easily accomedate the password inside the input box.

Mobile

image

However, there is an issue when the user is on a mobile device. The input field is now much more narrow, not viewing the whole string. However, the user doesn't copy the password by selecting it in the input (as it's disabled), but uses the copy button on the right.

The user also has to type the whole password into the text box below, ensuring that the user actually copied the password from the box abow correctly.

I do not see this as an imediate issue, but could be a thing for later when we have a proper responsive design in place.

@startailcoon
Copy link
Contributor

startailcoon commented Jun 8, 2018

Using `<textarea>´ instead, resulting in the following layout.

Field is readonly and disabled, forcing the user to click the copy button as before. Firefox allow the textarea to be resized by standard.

Edge

image

Firefox

image

Mobile

image

svk31 pushed a commit that referenced this issue Jun 11, 2018
* Decreased font size for generated password output

* Enable wrapping long passwords
Using textarea instead of input

* #1562: Fix textarea attributes
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
* Decreased font size for generated password output

* Enable wrapping long passwords
Using textarea instead of input

* bitshares#1562: Fix textarea attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive
Projects
None yet
Development

No branches or pull requests

4 participants