Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5] Update Asset UX #1816

Closed
gibbsfromncis opened this issue Sep 5, 2018 · 17 comments
Closed

[5] Update Asset UX #1816

gibbsfromncis opened this issue Sep 5, 2018 · 17 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [6] UX Impact flag identifying the application User Experience
Milestone

Comments

@gibbsfromncis
Copy link
Contributor

Based on feedback on this issue - #1757 I guess we should increase max items on the page.

@svk31
Copy link
Contributor

svk31 commented Sep 5, 2018

I don't think that would help, you'd then have to scroll to see all items between clicking next page, making things worse.

@gibbsfromncis
Copy link
Contributor Author

@svk31 agree. Could we reach an agreement on adding option to select how many items user want to see on the page?

@startailcoon
Copy link
Contributor

startailcoon commented Sep 8, 2018

Once all the assets are loaded, as they always has to be like @svk31 states, the user should be able to change the amount of rows placed on their screen.

I suggest we make it possible to change it between 20, 50, 70, 100, 200 per page.

Maybe this addition would be good for all pages using pagination in the future.

@startailcoon startailcoon added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Sep 8, 2018
@froooze
Copy link
Collaborator

froooze commented Sep 9, 2018

25, 50, 100 and 200 options makes more sense to me.

@gibbsfromncis
Copy link
Contributor Author

@froooze @startailcoon I suppose 100 items is max because of API restrictions and I don't think it is fair to make some hacks to be able fetch more than 100 items.

@startailcoon
Copy link
Contributor

startailcoon commented Sep 9, 2018

The code fetches all items by API at once, you can tell the pagination to use any number I guess?

@gibbsfromncis
Copy link
Contributor Author

gibbsfromncis commented Sep 9, 2018

@startailcoon exactly but If I remember correct the limit of items to fetch per one call is 100 to do not overload backend. If it's possible to fetch more than 100 I'll do it but if not I want to say there is no reason do put effort on ability to fetch more than 100 items per page

@sschiessl-bcp
Copy link
Contributor

I suggest to add a "Show XX" combobox on the right side of
image

This combobox has 10 / 25 / 50 / 100 and All options, but also allows that the user enters a number by himself.

This needs evaluation / rating before claiming

@startailcoon
Copy link
Contributor

I like the option of a few predefined options for the user to chose from, but letting them input one by their own design as well.

It will need testing to make sure the UX is looking good/working in different window sizes and browsers.

As there is no change in how the data is fetched from server based on the users choice I see no reason to evaluate any API load.

@startailcoon startailcoon added the [6] UX Impact flag identifying the application User Experience label Sep 12, 2018
@gibbsfromncis
Copy link
Contributor Author

@sschiessl-bcp @startailcoon

Agree. I've checked the code and it looks like it fetches all items before page load.

Task is:

  • Add Select component to be able to manage amount of items on the page from the predefined list
  • Add Number component to be able to manage amount of items on the page manually

During this task screenshots of realization should be provided to approve it looks nice.

Estimate is 2h

I suggest to add a "Show XX" combobox on the right side of

@sschiessl-bcp I'll check the ability to do it like you wish but I suggest it's not possible because pagination renders by ant and takes 100% of width. If there is no chance to make it as you wish I'll take UX from there (I'll put Select & Number components above the table)
explore with existing nav v3

@sschiessl-bcp
Copy link
Contributor

I'd like to include one more thing if you are already touching it.

While the asset list is loading a loading indicator is shown over the whole page, disabling me to search or click on an asset (if e.g. the one I am looking for is already on first page).

I suggest to put the loading indicator in the top left of the screen (in your mockup in the same row as the Select component), which allows user interaction while loading. If user exits page while loading, loading should be stopped

@gibbsfromncis
Copy link
Contributor Author

gibbsfromncis commented Sep 14, 2018

@sschiessl-bcp definitely agreed. Also it would be nice to make overlay over the table "white" or "dark" depending on theme. Because it makes me crazy when I'm trying to click and nothing happened because of transparent overlay...

Updated estimate: 3h

@startailcoon
Copy link
Contributor

Would be very nice if you could make the loading asynchronous in the background and let the user interact with the list, filter and options during this time. The user should be notified that the list is still populating during this time though.

I think the pagination at the bottom and selection props at the top looks good.

  • View options to 10 / 25 / 50 / 100 is good options
  • Make sure it's theme independent
  • If possible, try to make sure the list works well in a smaller frame, like a mobile unit.

@startailcoon startailcoon changed the title Increase items on Assets page to max [3] Update Asset UX Sep 15, 2018
@startailcoon startailcoon added [3] Feature Classification indicating the addition of novel functionality to the design and removed [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Sep 15, 2018
@svk31
Copy link
Contributor

svk31 commented Sep 15, 2018

It's already async, it's just the loading indicator that blocks input.

gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Sep 27, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Sep 27, 2018
@sschiessl-bcp
Copy link
Contributor

PR referenced wrong issue

@sschiessl-bcp sschiessl-bcp reopened this Sep 27, 2018
@gibbsfromncis
Copy link
Contributor Author

gibbsfromncis commented Oct 2, 2018

Done. (btw default 25 items on page, I made 10 to be able to make screenshot of entire page)

screenshot 2018-10-03 01 09 28

screenshot 2018-10-03 01 09 11

screenshot 2018-10-03 01 09 02

screenshot 2018-10-03 01 08 49

@startailcoon @wmbutler please increase estimate to 5h for the reason it took more time than I suggested.

gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Oct 2, 2018
@startailcoon startailcoon changed the title [3] Update Asset UX [5] Update Asset UX Oct 4, 2018
@sschiessl-bcp sschiessl-bcp added this to the 181003 milestone Oct 5, 2018
@kristinlow
Copy link

Great improvement. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [6] UX Impact flag identifying the application User Experience
Projects
None yet
Development

No branches or pull requests

6 participants