Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.25][happyconcepts] Remove 3rd party java script Bitkapital #341

Closed
btsfav opened this issue Aug 30, 2017 · 13 comments
Closed

[.25][happyconcepts] Remove 3rd party java script Bitkapital #341

btsfav opened this issue Aug 30, 2017 · 13 comments
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone

Comments

@btsfav
Copy link

btsfav commented Aug 30, 2017

We decided earlier this year to not add the telegram widget because it means side loading scripts, a potential security leak.

but looks like bitkapital is doing exactly the same with their transfer service form

<script type="text/javascript" src="//cdn-main1.123contactform.com/modules/custom-components/js/custom-components.js.minified.js?398aa2b"></script>

https://github.com/bitshares/bitshares-ui/search?utf8=%E2%9C%93&q=123contactform&type=

so, delete?

@wmbutler
Copy link
Contributor

wmbutler commented Aug 30, 2017

I'm inclined to agree. @svk31 I'll place a small bounty on this but will retract it if you oppose. Seems to me that bitKapital should follow the same method as openledger for the time being. they can submit a PR for that.

While this technically isn't a bug, I don't have a better category for it.

@wmbutler wmbutler changed the title 3rd party java script Bitkapital [.25] Remove 3rd party java script Bitkapital Aug 30, 2017
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Aug 30, 2017
@btsfav
Copy link
Author

btsfav commented Aug 30, 2017

if you decide to delete: keep the tab and add "Currently under Maintenance" or something please.

@wmbutler
Copy link
Contributor

Agreed.

@happyconcepts
Copy link
Contributor

Agreed @btsfav @wmbutler
I will claim if ok.
Do you expect bK to come back with a PR soon?

@wmbutler wmbutler modified the milestone: 170914 Aug 31, 2017
@wmbutler wmbutler changed the title [.25] Remove 3rd party java script Bitkapital [.25][happyconcepts] Remove 3rd party java script Bitkapital Aug 31, 2017
@wmbutler
Copy link
Contributor

bK?

@happyconcepts
Copy link
Contributor

bitKapital.

@wmbutler
Copy link
Contributor

Ah, I don't know what they will do. I have no contact with them.

@btsfav
Copy link
Author

btsfav commented Sep 1, 2017

it's up to bitkapital to react / follow github if they want to issue a workaround, in my opinion.

@happyconcepts
Copy link
Contributor

happyconcepts commented Sep 2, 2017

So just to be clear, removing the form will not provide a way for users to make a deposit through bitkapital, for the time being, right?

@btsfav
Copy link
Author

btsfav commented Sep 2, 2017

@happyconcepts exactly, that's why I'd like to see a "under maintenance" message appearing under the tab

@happyconcepts
Copy link
Contributor

"Onarım" in turkish - got it, thanks

happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Sep 2, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Sep 2, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Sep 2, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Sep 2, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Sep 2, 2017
svk31 pushed a commit that referenced this issue Sep 5, 2017
* Update README.md

* #341 remove 3rd party script call

* header for test #341

* #341 deposit maintenance tout

* #341 remove testing header

* #341
@svk31 svk31 closed this as completed Sep 5, 2017
@happyconcepts
Copy link
Contributor

@wmbutler will you please check this [0.25] as I did not see it come through with #358 on 170914. Thanks!

@wmbutler
Copy link
Contributor

Oops. Just covered this for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Development

No branches or pull requests

4 participants