-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.25][happyconcepts] Remove 3rd party java script Bitkapital #341
Comments
I'm inclined to agree. @svk31 I'll place a small bounty on this but will retract it if you oppose. Seems to me that bitKapital should follow the same method as openledger for the time being. they can submit a PR for that. While this technically isn't a bug, I don't have a better category for it. |
if you decide to delete: keep the tab and add "Currently under Maintenance" or something please. |
Agreed. |
bK? |
bitKapital. |
Ah, I don't know what they will do. I have no contact with them. |
it's up to bitkapital to react / follow github if they want to issue a workaround, in my opinion. |
So just to be clear, removing the form will not provide a way for users to make a deposit through bitkapital, for the time being, right? |
@happyconcepts exactly, that's why I'd like to see a "under maintenance" message appearing under the tab |
"Onarım" in turkish - got it, thanks |
Oops. Just covered this for you. |
We decided earlier this year to not add the telegram widget because it means side loading scripts, a potential security leak.
but looks like bitkapital is doing exactly the same with their transfer service form
<script type="text/javascript" src="//cdn-main1.123contactform.com/modules/custom-components/js/custom-components.js.minified.js?398aa2b"></script>
https://github.com/bitshares/bitshares-ui/search?utf8=%E2%9C%93&q=123contactform&type=
so, delete?
The text was updated successfully, but these errors were encountered: