Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.25][zhyupe] QR code background color should be white #938

Closed
xiangxn opened this issue Jan 1, 2018 · 5 comments
Closed

[.25][zhyupe] QR code background color should be white #938

xiangxn opened this issue Jan 1, 2018 · 5 comments
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180108

Comments

@xiangxn
Copy link
Contributor

xiangxn commented Jan 1, 2018

QR code background color should be white, otherwise it will affect the recognition success rate, especially in the identification of pure js.
@startailcoon
Copy link
Contributor

Please specify in what places it is not white, and we will make sure it is.

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 1, 2018 •
edited
Loading

the QR code in Private key viewer

98b11c31-b09a-4994-8244-4d1f17e14029

@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Jan 2, 2018
@wmbutler wmbutler changed the title QR code background color should be white [.25] QR code background color should be white Jan 2, 2018
@wmbutler wmbutler added this to the 180105 milestone Jan 2, 2018
@zhyupe
Copy link
Contributor

zhyupe commented Jan 3, 2018

I'd like to claim this issue.

zhyupe added a commit to zhyupe/bitshares-ui that referenced this issue Jan 3, 2018
@zhyupe
Fix bitshares#938: Add white background to qrcode
ecc9463
@zhyupe zhyupe mentioned this issue Jan 3, 2018
Merged
@wmbutler wmbutler changed the title [.25] QR code background color should be white [.25][zhyupe] QR code background color should be white Jan 4, 2018
@svk31 svk31 closed this as completed in #948 Jan 5, 2018
svk31 pushed a commit that referenced this issue Jan 5, 2018
@zhyupe @svk31
Fix #938: Add white background to qrcode (#948)
d36bce7
@wmbutler
Copy link
Contributor

Please provide your bts address for payment

@zhyupe
Copy link
Contributor

zhyupe commented Jan 12, 2018

@wmbutler My address is zhyupe

Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@zhyupe @svk31
Fix bitshares#938: Add white background to qrcode (bitshares#948)
1525ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180108
Development

No branches or pull requests
4 participants
@wmbutler @zhyupe @xiangxn @startailcoon