Fix Issue #691 - Flash on Price Change #870

startailcoon · 2017-12-14T17:50:43Z

Proposal for Issue #691

Not sure if this is the most efficient model, but it works when I try it.

Added Los Angeles API Node

merge staging

fix merge issue

- Store previous change state w/ timestamp - Pulsate with Up/Down flashing colors

startailcoon · 2017-12-14T18:08:34Z

Still to do:

Consider flash colors
Consider if more than %-change should flash

svk31 · 2017-12-14T18:38:31Z

app/components/Exchange/MyMarkets.jsx

@@ -58,12 +59,40 @@ class MarketGroup extends React.Component {
        return (
            !utils.are_equal_shallow(nextState, this.state) ||
            !utils.are_equal_shallow(nextProps.markets, this.props.markets) ||
+            nextState.marketsCache !== this.state.marketsCache ||


This will always return true, use utils.are_equal_shallow to compare arrays or objects.

- Flash expires correctly

startailcoon · 2017-12-14T20:56:52Z

Preview of the function. The delay is most likely due to me debugging and running a lot at the same time. The code adds/removes the desired flash class and is up to the browser/system.

…nto tianyekuo-staging

* added button to create account from accounts page * Add button to create new account in local wallet mode #800

- Flash only once on market change - Flash timer 2 seconds (WIP) Dashboard: - Initial setup

startailcoon · 2017-12-16T10:49:43Z

When trying to work with the change on the portfolio dashboard I get the following issue, and I have no idea how to fix it.

* modifiying table padding and borders * test * adding sorting by date * fixing to merge * fixing to merge

Fix invalid td coloring

…es-ui into 691_FlashOnPriceChange

svk31 · 2017-12-19T15:07:26Z

app/components/Account/AccountOverview.jsx

@@ -252,6 +278,9 @@ class AccountOverview extends React.Component {
            const canDepositWithdraw = !!this.props.backedCoins.get("OPEN", []).find(a => a.symbol === asset.get("symbol"));
            const canWithdraw = canDepositWithdraw && (hasBalance && balanceObject.get("balance") != 0);
            const canBuy = !!this.props.bridgeCoins.get(symbol);
+            const changeClass = !marketsCache[asset.get("id")] ? "" : marketsCache[asset.get("id")][1] == 0 ? "" : marketsCache[asset.get("id")][1] < 0 ? marketsCache[asset.get("id")][2] ? "pulsate-down" : "change-down" : marketsCache[asset.get("id")][2] ? "pulsate-up" : "change-up";


I don't think this line does what you think it does. The syntax is incorrect (too many : parts like here: ? "pulsate-down" : "change-down" : marketsCache[asset.get("id")][2]) and marketsCache[asset.get("id")][1] is a string so you should parse it before comparing it to 0.

svk31 · 2017-12-19T15:08:09Z

app/components/Exchange/MarketRow.jsx

+
+                case "change":
+                    let change = utils.format_number(stats && stats.change ? stats.change : 0, 2);
+                    let changeClass = change === "0.00" ? "" : change > 0 ? flash ? " pulsate-up" : " change-up" : flash ? " pulsate-down" : " change-down";


The syntax is incorrect here as well.

svk31 · 2017-12-19T15:08:29Z

app/components/Exchange/MarketRow.jsx

+                    }
+
+                    let change_on_price = utils.format_number(stats && stats.change ? stats.change : 0, 2);
+                    let changeClass_on_price = change_on_price === "0.00" ? "" : change_on_price > 0 ? flash ? " pulsate-up" : " change-up" : flash ? " pulsate-down" : " change-down";


svk31 · 2017-12-19T15:09:02Z

app/components/Exchange/MyMarkets.jsx

+        }
+
+        marketsCache[id][0] = timestamp;
+        marketsCache[id][1] = change;        


I recommend using parseFloat here for the change value.

svk31 · 2017-12-19T15:09:34Z

app/components/Exchange/MyMarkets.jsx

+            marketsCache[id] = [timestamp, "0.00", false];
+        }
+
+        if(change != marketsCache[id][1] && marketsCache[id][1] != "0.00") { 


Parsing as float below means you can use !== 0 here. In general you should always use strict equalities.

svk31 · 2017-12-19T15:12:43Z

app/components/Utility/MarketChangeComponent.jsx

        let marketChangeValue = this.getValue();
-        let dayChangeClass = parseFloat(marketChangeValue) === 0 ? "" : parseFloat(marketChangeValue) < 0 ? "change-down" : "change-up";
+        let dayChangeClass = parseFloat(marketChangeValue) === 0 ? "" : parseFloat(marketChangeValue) < 0 ? flash ? "pulsate-down" : "change-down" : flash ? "pulsate-up" : "change-up";


This syntax is also incorrect.

startailcoon · 2017-12-27T19:20:18Z

I will rework this in a new branch and make a new PR once completed.

calvinfroedge and others added 16 commits December 9, 2017 18:20

Implement typeahead component

14cab27

Implement typeahead component

78d016f

Update apiConfig.js (#839)

e3d2200

Added Los Angeles API Node

Merge pull request #3 from bitshares/staging

0c271eb

merge staging

1. add with rule;2. add gdex asset; 3.

be7f37f

update language and fix typo

a0e8e15

delete asset to fix merge issue

3288ccf

Update SettingsStore.js

0d2706b

fix merge issue

Merge branch 'staging'

a4304d7

Merge branch 'staging'

41057e4

Merge branch 'staging'

a1e62f5

Set new appveyor token

27bba27

New appveyor token

2b93346

Add travis secure variable

05ccf4a

Enable Flash on Market Change

edeba2a

- Store previous change state w/ timestamp - Pulsate with Up/Down flashing colors

Clean accidental merge

c550397

svk31 added 2 commits December 14, 2017 19:32

Fix travis secure variable

270eb4a

Merge branch 'staging'

386a83e

svk31 reviewed Dec 14, 2017

View reviewed changes

Updated:

92d7bcd

- Flash expires correctly

svk31 and others added 8 commits December 15, 2017 09:07

Update travis key

72ff23a

Final travis key update

236344b

Merge branch 'staging' of https://github.com/tianyekuo/bitshares-ui i…

adae601

…nto tianyekuo-staging

Add GDEX prefix to replaceName

bad27fe

Merge branch 'tianyekuo-staging' into staging

d4ea70d

New faucet according to infrastructure worker proposal (#867)

0992baf

Fixed login mode change on registration page visit #831 (#871)

c303100

Fix #874: Check cloud wallet password against local wallet

92515a3

svk31 and others added 4 commits December 15, 2017 10:16

Merge branch 'staging' of github.com:bitshares/bitshares-ui into staging

b36ae83

Add button to create new account #800 (#872)

39e5677

* added button to create account from accounts page * Add button to create new account in local wallet mode #800

Fix #875: overflow hidden hiding password characters

ae46d0d

Exchange:

8e92eef

- Flash only once on market change - Flash timer 2 seconds (WIP) Dashboard: - Initial setup

startailcoon changed the title ~~Fix Issue #691 - Flash on Price Change~~ (WIP) Fix Issue #691 - Flash on Price Change Dec 17, 2017

startailcoon added 4 commits December 17, 2017 17:22

Update MarketChangeComponent.jsx

c449f93

Update AccountOverview.jsx

95905c7

Update MarketChangeComponent.jsx

d74c2e4

Update AccountOverview.jsx

665892c

startailcoon changed the title ~~(WIP) Fix Issue #691 - Flash on Price Change~~ Fix Issue #691 - Flash on Price Change Dec 17, 2017

maiopirata and others added 7 commits December 18, 2017 16:20

Sorting News by Date (#881)

f960498

* modifiying table padding and borders * test * adding sorting by date * fixing to merge * fixing to merge

Correctly parse signed message (#864)

c86c8db

Right and left align asset name columns in MyOpenOrders

9a9d3c6

Merge branch 'staging' into 691_FlashOnPriceChange

47b29c3

Update AccountOverview.jsx

250121c

Fix invalid td coloring

Revert Flash Volume on Market

475e0ac

Merge branch '691_FlashOnPriceChange' of github.com:bitshares/bitshar…

bfd8bf5

…es-ui into 691_FlashOnPriceChange

svk31 suggested changes Dec 19, 2017

View reviewed changes

Fix some dataflow issues and refactor change check methods

b678ced

startailcoon closed this Dec 27, 2017

svk31 mentioned this pull request Dec 2, 2017

Show indication for insufficient funds for proposed transaction fee #64

Closed

svk31 deleted the 691_FlashOnPriceChange branch April 3, 2018 10:38

takeratta mentioned this pull request Nov 28, 2023

[Snyk] Fix for 11 vulnerabilities takeratta/cryptobridge-ui#4

Open

takeratta mentioned this pull request Apr 16, 2024

[Snyk] Fix for 1 vulnerabilities takeratta/cryptobridge-ui#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Issue #691 - Flash on Price Change #870

Fix Issue #691 - Flash on Price Change #870

startailcoon commented Dec 14, 2017

startailcoon commented Dec 14, 2017 •

edited

svk31 Dec 14, 2017

startailcoon commented Dec 14, 2017 •

edited

startailcoon commented Dec 16, 2017

svk31 Dec 19, 2017

svk31 Dec 19, 2017

svk31 Dec 19, 2017

svk31 Dec 19, 2017

svk31 Dec 19, 2017

svk31 Dec 19, 2017

startailcoon commented Dec 27, 2017

Fix Issue #691 - Flash on Price Change #870

Fix Issue #691 - Flash on Price Change #870

Conversation

startailcoon commented Dec 14, 2017

startailcoon commented Dec 14, 2017 • edited

svk31 Dec 14, 2017

Choose a reason for hiding this comment

startailcoon commented Dec 14, 2017 • edited

startailcoon commented Dec 16, 2017

svk31 Dec 19, 2017

Choose a reason for hiding this comment

svk31 Dec 19, 2017

Choose a reason for hiding this comment

svk31 Dec 19, 2017

Choose a reason for hiding this comment

svk31 Dec 19, 2017

Choose a reason for hiding this comment

svk31 Dec 19, 2017

Choose a reason for hiding this comment

svk31 Dec 19, 2017

Choose a reason for hiding this comment

startailcoon commented Dec 27, 2017

startailcoon commented Dec 14, 2017 •

edited

startailcoon commented Dec 14, 2017 •

edited