Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mint and support IntoMint trait #250

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

LPGhatguy
Copy link
Contributor

In mint 0.5.8, the IntoMint trait was introduced. This trait helps users convert between math library types directly without having to name mint types themselves. More details on this trait are in kvark/mint#59 and kvark/mint#68.

This PR updates the mint minimum version to 0.5.8 and implements IntoMint for all types that have existing mint conversions.

@bitshifter
Copy link
Owner

Sorry, been busy the last couple of days and forgot to press the button. Looks like there's a test fail there. You can run these .sh files locally if that's easier.

@LPGhatguy
Copy link
Contributor Author

LPGhatguy commented Oct 23, 2021

Huh. The compilation error is with mint, not with the changes to glam. I wonder if rustc 1.51.0 is too old to work with the way the trait is defined.

I opened an issue for mint here because it seems there may not be a proper MSRV defined: kvark/mint#70

@bitshifter
Copy link
Owner

I'm not opposed to updating the MSRV if needed, it's a bit unclear what feature this needs.

@LPGhatguy
Copy link
Contributor Author

It appears that mint requires a trait resolution change introduced in Rust 1.52.0. I don't see this documented in Rust's changelog.

I've introduced a PR for Mint, kvark/mint#71, which introduces a proper MSRV to prevent issues like this happening in the future. We've set the minimum version to 1.52.1.

@bitshifter
Copy link
Owner

This will get a lot easier with Rust 1.56 https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html#cargo-rust-version.It just came out though so not sure I want to jump on it straight away.

@bitshifter bitshifter merged commit dd61905 into bitshifter:main Oct 26, 2021
@bitshifter
Copy link
Owner

I updated glam's MSVR to 1.52.1,

@LPGhatguy LPGhatguy deleted the into-mint branch October 26, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants