Add totp copy to clipboard button to cipher view #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGibson1
force-pushed
the
add-quick-totp-copy
branch
4 times, most recently
from
0c0af35 to
8338475
Compare
MGibson1
force-pushed
the
add-quick-totp-copy
branch
from
8338475 to
ef46f8c
Compare
cscharf
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Also need to consider proper permissions/capabilities (not just the existence of a TOTP value configured).
see: https://github.com/bitwarden/jslib/blob/master/src/angular/components/view.component.ts#L92
cscharf
reviewed
Dec 15, 2020
cscharf
approved these changes
Dec 15, 2020
|
Should this be hidden if you don't have premium? |
|
@ajayyy I decided not to do that since the CipherView doesn't hide it. It might make sense to add mouseover text that it's a premium feature. |
addisonbeck
pushed a commit
that referenced
this pull request
May 5, 2022
* Fix radiobutton names * Add role=radiogroup * Add aria-labelledby
eliykat
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Offering copying of totp from context menu covers only one method-of-use. Offering another quick-copy button on the tabs/cipher list view closes this gap.
Files Changed
action-buttons are responsible for populating the quick-action buttons to the right of cipher names in the cipher list view.
Screenshots
With and without Totp
Draft Reason
Waiting on bitwarden/jslib#225