Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n layout redress #4920

Closed
1 task
atx49559 opened this issue Mar 3, 2023 · 3 comments · Fixed by #4932
Closed
1 task

i18n layout redress #4920

atx49559 opened this issue Mar 3, 2023 · 3 comments · Fixed by #4932
Labels
browser Browser Extension bug

Comments

@atx49559
Copy link

atx49559 commented Mar 3, 2023

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. Click on '...'

Expected Result

Right layout, maybe let the width more larger.

Actual Result

location zh-tw

2023-03-03 14-22-30 的螢幕擷圖

Screenshots or Videos

No response

Additional Context

No response

Operating System

Windows

Operating System Version

No response

Web Browser

Brave

Browser Version

No response

Build Version

2023.2.1

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@atx49559 atx49559 added browser Browser Extension bug labels Mar 3, 2023
@patrickhlauke
Copy link
Contributor

patrickhlauke commented Mar 3, 2023

This could be fixed with a white-space: pre; on the button element there...

screenshot of the fixed back button, showing devtools with white-space:pre added to the button styles

but I'm actually wondering if it wouldn't be cleaner to remove the visible text and just rely on the graphical arrow/chevron icon, as this element otherwise varies wildly in width depending on language, leading to awkward-looking layouts where the search box varies in width all over the place. thoughts @danielleflinn ? (happy to make a PR either way)

@patrickhlauke
Copy link
Contributor

Filed a fix #4932

@atx49559
Copy link
Author

atx49559 commented Mar 6, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants