Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1260] Removed ssoRequired field from the sso details response #5123

Merged
merged 3 commits into from
Apr 3, 2023
Merged

[AC-1260] Removed ssoRequired field from the sso details response #5123

merged 3 commits into from
Apr 3, 2023

Conversation

gbubemismith
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Linked to this PR. Remove the unused ssoRequired field.

Code changes

Modified sso details response model to conform to the changes on the server.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@gbubemismith gbubemismith requested a review from a team as a code owner March 30, 2023 21:45
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gbubemismith gbubemismith removed the needs-qa Marks a PR as requiring QA approval label Apr 3, 2023
JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gbubemismith gbubemismith merged commit a78ed4c into master Apr 3, 2023
@gbubemismith gbubemismith deleted the AC-1260 branch April 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbubemismith @JaredSnider-Bitwarden