Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defect/AC-1267 - Fix Login Master Pass Entry Prematurely Showing Validation Errors #5246

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Defect/AC-1267 - Fix Login Master Pass Entry Prematurely Showing Validation Errors #5246

merged 1 commit into from
Apr 25, 2023

Conversation

JaredSnider-Bitwarden
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Apr 20, 2023 •
edited by jira bot
Loading

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

AC-1267 - Fix Login Master Pass Entry Prematurely Showing Validation Errors

Code changes

  • libs/angular/src/auth/components/login.component.ts:
    • Mark master pass (MP) field as untouched on any load of MP section of login page post email validation in order to prevent validation errors of "input required" from being shown prematurely before the user has entered anything or lost focus on the input when the user hits enter on the login screen after entering an email
    • Improve the logic around the MP autofocus to match existing code patterns to ensure there are no possible scenarios in which the MP would not be autofocused.

Screenshots

AC-1267.-.Fix.login.MP.entry.prematurely.showing.validation.errors.mov

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@JaredSnider-Bitwarden
AC-1267 - (1) Mark master pass (MP) field as untouched on any load of…
bb96513 
… MP section of login page post email validation in order to prevent validation errors of "input required" from being shown prematurely before the user has entered anything or lost focus on the input when the user hits enter on the login screen after entering an email (2) Improve the logic around the MP autofocus to match existing code patterns to ensure there are no possible scenarios in which the MP would not be autofocused.
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 20, 2023
@JaredSnider-Bitwarden JaredSnider-Bitwarden marked this pull request as ready for review April 20, 2023 22:08
@JaredSnider-Bitwarden JaredSnider-Bitwarden requested a review from a team as a code owner April 20, 2023 22:08
jlf0dev
jlf0dev approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@jlf0dev jlf0dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredSnider-Bitwarden
Copy link
Contributor Author

QA tested and approved merge.

@JaredSnider-Bitwarden JaredSnider-Bitwarden removed the needs-qa Marks a PR as requiring QA approval label Apr 25, 2023
@JaredSnider-Bitwarden JaredSnider-Bitwarden merged commit 85277aa into master Apr 25, 2023
@JaredSnider-Bitwarden JaredSnider-Bitwarden deleted the defect/AC-1267-login-mp-entry-prematurely-shows-validation-errors branch April 25, 2023 14:09
@djsmith85 djsmith85 mentioned this pull request May 8, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlf0dev jlf0dev jlf0dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredSnider-Bitwarden @jlf0dev