Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-2368] Add fullSync on successful import #5500

Merged
merged 1 commit into from
May 30, 2023
Merged

[PM-2368] Add fullSync on successful import #5500

merged 1 commit into from
May 30, 2023

Conversation

djsmith85
Copy link
Contributor

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Analog to #4380 we also need to add a full sync to the import.command, so that when a user calls bw list items those are populated.

Code changes

  • apps/cli/src/vault.program.ts: Pass in the syncService into the importCommand
  • apps/cli/src/tools/import.command.ts: Require syncService and call fullSync after a successful import.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@djsmith85
Add fullSync on successful import
cdadd50 
Analog to #4380 we also need to add a full sync to the import.command, so that when a user calls `bw list items` those are populated.
@djsmith85 djsmith85 requested a review from a team as a code owner May 23, 2023 19:23
@djsmith85 djsmith85 added the needs-qa Marks a PR as requiring QA approval label May 23, 2023
aj-rosado
aj-rosado approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@aj-rosado aj-rosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good

@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label May 30, 2023
@djsmith85 djsmith85 merged commit 4a55234 into master May 30, 2023
@djsmith85 djsmith85 deleted the pm-2368-sync-after-import branch May 30, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-rosado aj-rosado aj-rosado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djsmith85 @aj-rosado