Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor StaticStore Plans and consuming logic #6136

Merged
merged 16 commits into from
Oct 17, 2023
Merged

Refactor StaticStore Plans and consuming logic #6136

merged 16 commits into from
Oct 17, 2023

Conversation

cyprain-okeke
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Modify the client to use the refactored PlanResponseModel and eliminate the old implementation that has secrets plan, bitwardenProducttype enum and password plan

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@cyprain-okeke cyprain-okeke requested review from a team as code owners August 29, 2023 08:48
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Aug 29, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Aug 29, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 8606d992-68a9-46e7-86b0-771775f2d53f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19 Attack Vector

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner October 2, 2023 09:13
eliykat
eliykat previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC Team + tech lead changes look good.

Can you please get a review from within Billing Team on the rest of the changes, there's no need for me to review them given that I'm not a codeowner and they should just flow from what we've already done on the server.

amorask-bitwarden
amorask-bitwarden previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from @bitwarden/team-billing.

cturnbull-bitwarden
cturnbull-bitwarden previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @cyprain-okeke !

eliykat
eliykat previously approved these changes Oct 12, 2023
View reviewed changes
@cyprain-okeke cyprain-okeke requested review from eliykat and removed request for eliykat October 16, 2023 19:33
@cyprain-okeke cyprain-okeke removed the needs-qa Marks a PR as requiring QA approval label Oct 16, 2023
@cyprain-okeke cyprain-okeke merged commit 5cacd79 into master Oct 17, 2023
39 of 40 checks passed
@cyprain-okeke cyprain-okeke deleted the ac-1604/modify-the-client-with-refactored-plan-model branch October 17, 2023 14:57
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
@cyprain-okeke @BlackDex
Refactor StaticStore Plans and consuming logic (bitwarden#6136)
6b1fd14 
* staticstore factoring changes

* Refactoring code changes

* fix the free org issue

* remove a depreciated endpoint

* Resolve the issue of secrets manager sub

* Fix the ui product sorting
quexten pushed a commit to quexten/clients that referenced this pull request Feb 10, 2024
@cyprain-okeke @quexten
Refactor StaticStore Plans and consuming logic (bitwarden#6136)
4169a33 
* staticstore factoring changes

* Refactoring code changes

* fix the free org issue

* remove a depreciated endpoint

* Resolve the issue of secrets manager sub

* Fix the ui product sorting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorask-bitwarden amorask-bitwarden amorask-bitwarden approved these changes

@cturnbull-bitwarden cturnbull-bitwarden cturnbull-bitwarden approved these changes

@eliykat eliykat eliykat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyprain-okeke @bitwarden-bot @eliykat @cturnbull-bitwarden @amorask-bitwarden