[AC 2413] migrate policies component #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8692 +/- ##
==========================================
+ Coverage 28.12% 28.13% +0.01%
==========================================
Files 2362 2362
Lines 69880 69880
Branches 13141 13141
==========================================
+ Hits 19654 19661 +7
+ Misses 48668 48661 -7
Partials 1558 1558 ☔ View full report in Codecov by Sentry. |
|
New Issues
|
vincentsalucci
requested review from
eliykat
and removed request for
vincentsalucci
eliykat
requested changes
May 1, 2024
| <bit-table *ngIf="!loading"> | ||
| <ng-template body> | ||
| <tr bitRow *ngFor="let p of policies"> | ||
| <td bitCell *ngIf="p.display(organization)"> | ||
| <a href="#" appStopClick (click)="edit(p)">{{ p.name | i18n }}</a> |
There was a problem hiding this comment.
While you're here, can you please change this to use a CL button link:
Suggested change
| <a href="#" appStopClick (click)="edit(p)">{{ p.name | i18n }}</a> | |
| <button bitLink (click)="edit(p)">{{ p.name | i18n }}</button> |
…413-Migrate-policies-component
eliykat
approved these changes
May 5, 2024
quexten
pushed a commit
that referenced
this pull request
May 22, 2024
* migrate policies component * migrate policies component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Migrate the Policy component to use the component library.
policies.component.html - Updated the bootstrap css to use the equivalent components from the Component Library.
Screenshots
policies.-.Made.with.Clipchamp.mp4