Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7175] Create vault settings component (navigational changes) #8840

Merged
merged 21 commits into from
May 7, 2024

Merge branch 'main' of https://github.com/bitwarden/clients into tool…

899188c
Select commit
Loading
Failed to load commit list.
Merged

[PM-7175] Create vault settings component (navigational changes) #8840

Merge branch 'main' of https://github.com/bitwarden/clients into tool…
899188c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 7, 2024 in 39s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method account-security.component.ts: AccountSecurityComponent.ngOnInit
  • Complex Method account-security.component.ts: AccountSecurityComponent.updateBiometric

Annotations

Check warning on line 235 in apps/browser/src/auth/popup/settings/account-security.component.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

AccountSecurityComponent.ngOnInit has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 402 in apps/browser/src/auth/popup/settings/account-security.component.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

AccountSecurityComponent.updateBiometric has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.