Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

feat(platform-utils): Get and react to changes to the system theme #161

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

sorin-davidoi
Copy link
Contributor

@sorin-davidoi sorin-davidoi commented Aug 31, 2020

These changes will allow the WebExtension (and later the desktop application) to respect the system theme.

I've added the Electron implementation until I realized that the required API has been implemented but not released yet. Let me know if I should remove the code.

Part of bitwarden/clients#1256.

These changes will allow the WebExtension (and later the desktop application) to respect the system theme.

I've added the Electron implementation until I realized that the required API [has been implemented but not released yet](https://www.electronjs.org/docs/api/native-theme/history). Let me know if you I should remove the code.

Part of bitwarden/clients#1256.

https://www.electronjs.org/docs/api/native-theme
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2020

CLA assistant check
All committers have signed the CLA.

sorin-davidoi added a commit to sorin-davidoi/browser that referenced this pull request Aug 31, 2020
kspearrin
kspearrin previously approved these changes Sep 3, 2020
@kspearrin
Copy link
Member

Looks good, but we will need to merge this after our next release.

@sorin-davidoi
Copy link
Contributor Author

There seems to have been a minor release since the pull request was opened.

@sorin-davidoi
Copy link
Contributor Author

@kspearrin Is there anything I can do here?

@cscharf cscharf merged commit 58f5369 into bitwarden:master Dec 15, 2020
@sorin-davidoi sorin-davidoi deleted the platform-utils-system-theme branch December 16, 2020 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants