[EC-142] Fix error during import of 1pux containing new email field format

[djsmith85]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

Some user where experiencing issues while importing a 1pux export into Bitwarden. The reason being, that a new email field type was introduced which got parsed incorrectly. This caused corruption while encrypting into a Bitwarden identity type and failed the import.

I also discovered that these email fields got falsely skipped and should have been imported as custom fields.

Old format

"value": {
    "string": "someuser@someprovider.com"
},

New format

"value": {
    "email": {
        "email_address": "someuser@someprovider.com",
        "provider": null
    }
},

Original report: bitwarden/web#1548

Code changes

• common/src/importers/onepasswordImporters/types/onepassword1PuxImporterTypes.ts: Change type of email field typefrom string to object
• common/src/importers/onepasswordImporters/onepassword1PuxImporter.ts:
  • Import complex email field type as custom field
  • Import complex email field type as email field on identities
  • Only save in indentity.email if it is empty, if not save as custom field
  • If provider property of email field is filled, save it as custom field
• common/spec/importers/onepassword1PuxImporter.spec.ts: Add additional test cases for complex email field
• common/spec/importers/testData/onePassword1Pux/*.ts:
  • Files with testdata to support the test cases
  • Fixed formatting of existing test data files

Testing requirements

Test cases will be described on the web PR following this, after merge.

Before you submit

• I have checked for linting errors (npm run lint) (required)
• I have added unit tests where it makes sense to do so (encouraged but not required)
• This change requires a documentation update (notify the documentation team)
• This change has particular deployment requirements (notify the DevOps team)

[differsthecat]

Looks good!