Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET resolve suggested warnings #247

Merged
merged 3 commits into from
Sep 21, 2023
Merged

.NET resolve suggested warnings #247

merged 3 commits into from
Sep 21, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 21, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

  • Upgrade logo to 128x128 which is the recommended size on nuget.org.
  • Resolve warnings suggested by Rider
  • Execute reformat and cleanup in Rider.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton force-pushed the ps/dotnet-resolve-jetbrain-warnings branch from 8898450 to e79c3d1 Compare September 21, 2023 18:46
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 21, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 7ca2945d-07a6-4c21-ba3d-1527c2bc5d31

No New Or Fixed Issues Found

justindbaur
justindbaur approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

languages/csharp/Bitwarden.Sdk/bitwarden.png Show resolved Hide resolved
@Hinton Hinton merged commit bbbfdc6 into master Sep 21, 2023
44 checks passed
@Hinton Hinton deleted the ps/dotnet-resolve-jetbrain-warnings branch September 21, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justindbaur justindbaur justindbaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @justindbaur