Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable error coloring when specified by the user #61

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Disable error coloring when specified by the user #61

merged 1 commit into from
Jun 5, 2023

Conversation

dani-garcia
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes #50. Also added support for NO_COLOR, which clap already respects, but we didn't.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

Hinton
Hinton approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@dani-garcia dani-garcia merged commit 796a1be into master Jun 5, 2023
@dani-garcia dani-garcia deleted the fix-color-errors branch June 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--color no not respected for errors
2 participants
@dani-garcia @Hinton