[PM-8275] Remove sensitive #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
==========================================
- Coverage 59.47% 58.55% -0.93%
==========================================
Files 180 178 -2
Lines 11753 11405 -348
==========================================
- Hits 6990 6678 -312
+ Misses 4763 4727 -36 ☔ View full report in Codecov by Sentry. |
Hinton
force-pushed
the
ps/allocator-undo-sensitive
branch
from
9ccfb24
to
5c15808
Compare
…ator-undo-sensitive
…ator-undo-sensitive
…o-sensitive # Conflicts: # crates/bitwarden-c/Cargo.toml # crates/bitwarden-crypto/Cargo.toml # crates/bitwarden-crypto/src/allocator.rs # crates/bitwarden-crypto/src/lib.rs # crates/memory-testing/src/main.rs
…o-sensitive # Conflicts: # crates/bitwarden-json/src/client.rs # crates/bitwarden/src/client/client.rs # crates/bitwarden/src/tool/send.rs # crates/bitwarden/src/vault/collection.rs # crates/bitwarden/src/vault/folder.rs # crates/bitwarden/src/vault/password_history.rs
dani-garcia
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Wraps up the custom allocator effort introduced in #788 by removing the now no longer needed
Sensitivetype.Before you submit