Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using a internal namespace #804

Closed
wants to merge 1 commit into from
Closed

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 27, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ e21f4285-6fc6-4e2b-af2c-3d670e443b85

Fixed Issues

Severity Issue Source File / Package
HIGH Command_Injection /languages/python/example.py: [35](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/python/example.py# L35)
HIGH Command_Injection /languages/python/example.py: [66](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/python/example.py# L66)
HIGH Reflected_XSS /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: [379](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt# L379)
MEDIUM Missing_HSTS_Header /languages/php/example.php: [3](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/php/example.php# L3)
MEDIUM Parameter_Tampering /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: [379](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt# L379)
MEDIUM Privacy_Violation /languages/go/example/example.go: [103](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/go/example/example.go# L103)
MEDIUM Privacy_Violation /languages/java/Example.java: [13](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/java/Example.java# L13)
MEDIUM Privacy_Violation /languages/java/Example.java: [12](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/java/Example.java# L12)
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: [40](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java# L40)
MEDIUM Unchecked_Input_for_Loop_Condition /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: [379](https://github.com/bitwarden/sdk/blob/ps/core-internal//languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt# L379)
LOW Missing_CSP_Header /about.hbs: [48](https://github.com/bitwarden/sdk/blob/ps/core-internal//about.hbs# L48)

@Hinton
Copy link
Member Author

Hinton commented Jun 10, 2024

We decided to go this route, but it will be implemented in #798

@Hinton Hinton closed this Jun 10, 2024
@Hinton Hinton deleted the ps/core-internal branch June 10, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant