Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8092] Update reqwest and rustls platform verifier #851

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8092

📔 Objective

The new release of reqwest yesterday now unblocks our update to rustls-platform-verifier 0.3.1

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia changed the title [PM-8098] Update reqwest and rustls platform verifier [PM-8092] Update reqwest and rustls platform verifier Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

Logo
Checkmarx One – Scan Summary & Details9988a6d0-287e-4e58-b529-ad194f3ee46a

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.86%. Comparing base (547d0f2) to head (bdbfc07).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   59.83%   59.86%   +0.02%     
==========================================
  Files         189      189              
  Lines       12457    12457              
==========================================
+ Hits         7454     7457       +3     
+ Misses       5003     5000       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia force-pushed the ps/update-reqwest-and-rustls-platform-verifier branch from da9818d to ab933e6 Compare June 18, 2024 09:09
@dani-garcia dani-garcia requested a review from Hinton June 18, 2024 10:52
Hinton
Hinton previously approved these changes Jun 18, 2024
# Conflicts:
#	crates/bitwarden-fido/Cargo.toml
@dani-garcia dani-garcia merged commit 00b2120 into main Jun 18, 2024
104 checks passed
@dani-garcia dani-garcia deleted the ps/update-reqwest-and-rustls-platform-verifier branch June 18, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants