-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1174] Access Token Login State by Default in bws #930
Conversation
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 58.45% 58.41% -0.04%
==========================================
Files 194 195 +1
Lines 13358 13406 +48
==========================================
+ Hits 7808 7831 +23
- Misses 5550 5575 +25 ☔ View full report in Codecov by Sentry. |
…ue to attempt program execution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM
b5961a5
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1174
📔 Objective
This PR switches
bws
to use access token login state by default. This will help prevent many users from running into rate limiting issues. The two related config keys in a profile:state_dir
-> this is the same as it has been; a custom directory for where state files will be storedstate_opt_out
-> this is a new key. If it'strue
or1
, state files will not be usedNote: the
gnu
build failures are already happening onmain
and have been brought up internally⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes